| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <07a16be1-3f96-374c-3a9b-e3920bb4b437@gmail.com>
Date: Fri, 3 Feb 2023 13:22:38 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Markus Schneider-Pargmann <msp@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Chun-Jie Chen <chun-jie.chen@...iatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Fabien Parent <parent.f@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Fabien Parent <fparent@...libre.com>
Subject: Re: [PATCH 8/8] soc: mediatek: pm-domains: Add support for MT8365
On 05/01/2023 18:07, Markus Schneider-Pargmann wrote:
> From: Fabien Parent <fparent@...libre.com>
>
> Add the needed board data to support MT8365 SoC.
>
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> ---
> drivers/soc/mediatek/mt8365-pm-domains.h | 147 +++++++++++++++++++++++
> drivers/soc/mediatek/mtk-pm-domains.c | 5 +
> 2 files changed, 152 insertions(+)
> create mode 100644 drivers/soc/mediatek/mt8365-pm-domains.h
>
> diff --git a/drivers/soc/mediatek/mt8365-pm-domains.h b/drivers/soc/mediatek/mt8365-pm-domains.h
> new file mode 100644
> index 000000000000..8735e833b15b
> --- /dev/null
> +++ b/drivers/soc/mediatek/mt8365-pm-domains.h
> @@ -0,0 +1,147 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#ifndef __SOC_MEDIATEK_MT8365_PM_DOMAINS_H
> +#define __SOC_MEDIATEK_MT8365_PM_DOMAINS_H
> +
> +#include "mtk-pm-domains.h"
> +#include <dt-bindings/power/mediatek,mt8365-power.h>
> +
> +/*
> + * MT8365 power domain support
> + */
> +
> +static const struct scpsys_domain_data scpsys_domain_data_mt8365[] = {
> + [MT8365_POWER_DOMAIN_MM] = {
> + .name = "mm",
> + .sta_mask = PWR_STATUS_DISP,
> + .ctl_offs = 0x30c,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(8, 8),
> + .sram_pdn_ack_bits = GENMASK(12, 12),
> + .caps = MTK_SCPD_STRICT_BUS_PROTECTION | MTK_SCPD_HAS_WAY_EN,
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(16) | BIT(17), 0x2a8, 0x2ac, 0x258),
> + BUS_PROT_WR(BIT(1) | BIT(2) | BIT(10) | BIT(11), 0x2a0, 0x2a4, 0x228),
> + BUS_PROT_WAY_EN(BIT(6), 0x200, BIT(24), 0x0),
> + BUS_PROT_WAY_EN(BIT(5), 0x234, BIT(14), 0x28),
> + BUS_PROT_WR(BIT(6), 0x2a0, 0x2a4, 0x228),
BUS_PROT_WR(BIT(6), 0x2a0, 0x2a4, 0x228) repeates several times in the
definition. Would it make sense to create a new define like we did with
BUS_PROT_UPDATE_TOPAXI()? Are this offests are used in other SoCs.
In any case instead of magic numbers the values should be defined in
include/linux/soc/mediatek/infracfg.h or appropiate header files.
Regards,
Matthias
> + },
> + },
> + [MT8365_POWER_DOMAIN_VENC] = {
> + .name = "venc",
> + .sta_mask = PWR_STATUS_VENC,
> + .ctl_offs = 0x0304,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(8, 8),
> + .sram_pdn_ack_bits = GENMASK(12, 12),
> + .bp_smi = {
> + BUS_PROT_WR(BIT(1), 0x3c4, 0x3c8, 0x3c0),
> + },
> + },
> + [MT8365_POWER_DOMAIN_AUDIO] = {
> + .name = "audio",
> + .sta_mask = PWR_STATUS_AUDIO,
> + .ctl_offs = 0x0314,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(12, 8),
> + .sram_pdn_ack_bits = GENMASK(17, 13),
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(27) | BIT(28), 0x2a8, 0x2ac, 0x258),
> + },
> + .caps = MTK_SCPD_ACTIVE_WAKEUP,
> + },
> + [MT8365_POWER_DOMAIN_CONN] = {
> + .name = "conn",
> + .sta_mask = PWR_STATUS_CONN,
> + .ctl_offs = 0x032c,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = 0,
> + .sram_pdn_ack_bits = 0,
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(13), 0x2a0, 0x2a4, 0x228),
> + BUS_PROT_WR(BIT(18), 0x2a8, 0x2ac, 0x258),
> + BUS_PROT_WR(BIT(14), 0x2a0, 0x2a4, 0x228),
> + BUS_PROT_WR(BIT(21), 0x2a8, 0x2ac, 0x258),
> + },
> + .caps = MTK_SCPD_ACTIVE_WAKEUP | MTK_SCPD_KEEP_DEFAULT_OFF,
> + },
> + [MT8365_POWER_DOMAIN_MFG] = {
> + .name = "mfg",
> + .sta_mask = PWR_STATUS_MFG,
> + .ctl_offs = 0x0338,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(9, 8),
> + .sram_pdn_ack_bits = GENMASK(13, 12),
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(25), 0x2a0, 0x2a4, 0x228),
> + BUS_PROT_WR(BIT(21) | BIT(22), 0x2a0, 0x2a4, 0x228),
> + },
> + },
> + [MT8365_POWER_DOMAIN_CAM] = {
> + .name = "cam",
> + .sta_mask = BIT(25),
> + .ctl_offs = 0x0344,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(9, 8),
> + .sram_pdn_ack_bits = GENMASK(13, 12),
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(19), 0x2a8, 0x2ac, 0x258),
> + },
> + .bp_smi = {
> + BUS_PROT_WR(BIT(2), 0x3c4, 0x3c8, 0x3c0),
> + },
> + },
> + [MT8365_POWER_DOMAIN_VDEC] = {
> + .name = "vdec",
> + .sta_mask = BIT(31),
> + .ctl_offs = 0x0370,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(8, 8),
> + .sram_pdn_ack_bits = GENMASK(12, 12),
> + .bp_smi = {
> + BUS_PROT_WR(BIT(3), 0x3c4, 0x3c8, 0x3c0),
> + },
> + },
> + [MT8365_POWER_DOMAIN_APU] = {
> + .name = "apu",
> + .sta_mask = BIT(16),
> + .ctl_offs = 0x0378,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(14, 8),
> + .sram_pdn_ack_bits = GENMASK(21, 15),
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(2) | BIT(20), 0x2a8, 0x2ac, 0x258),
> + },
> + .bp_smi = {
> + BUS_PROT_WR(BIT(4), 0x3c4, 0x3c8, 0x3c0),
> + },
> + },
> + [MT8365_POWER_DOMAIN_DSP] = {
> + .name = "dsp",
> + .sta_mask = BIT(17),
> + .ctl_offs = 0x037C,
> + .pwr_sta_offs = 0x0180,
> + .pwr_sta2nd_offs = 0x0184,
> + .sram_pdn_bits = GENMASK(11, 8),
> + .sram_pdn_ack_bits = GENMASK(15, 12),
> + .bp_infracfg = {
> + BUS_PROT_WR(BIT(24) | BIT(30) | BIT(31), 0x2a8, 0x2ac, 0x258),
> + },
> + .caps = MTK_SCPD_ACTIVE_WAKEUP,
> + },
> +};
> +
> +static const struct scpsys_soc_data mt8365_scpsys_data = {
> + .domains_data = scpsys_domain_data_mt8365,
> + .num_domains = ARRAY_SIZE(scpsys_domain_data_mt8365),
> +};
> +
> +#endif /* __SOC_MEDIATEK_MT8365_PM_DOMAINS_H */
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
> index 29a9028dd9b3..adb7716df0a8 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.c
> +++ b/drivers/soc/mediatek/mtk-pm-domains.c
> @@ -23,6 +23,7 @@
> #include "mt8186-pm-domains.h"
> #include "mt8192-pm-domains.h"
> #include "mt8195-pm-domains.h"
> +#include "mt8365-pm-domains.h"
>
> #define MTK_POLL_DELAY_US 10
> #define MTK_POLL_TIMEOUT USEC_PER_SEC
> @@ -647,6 +648,10 @@ static const struct of_device_id scpsys_of_match[] = {
> .compatible = "mediatek,mt8195-power-controller",
> .data = &mt8195_scpsys_data,
> },
> + {
> + .compatible = "mediatek,mt8365-power-controller",
> + .data = &mt8365_scpsys_data,
> + },
> { }
> };
>
Powered by blists - more mailing lists