linux-kernel - Re: [PATCH linux-next] power: supply: test-power: use strscpy() to instead of? strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230203124622.fgvo2udbrto3grwv@mercury.elektranox.org>
Date:   Fri, 3 Feb 2023 13:46:22 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     yang.yang29@....com.cn
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        xu.panda@....com.cn
Subject: Re: [PATCH linux-next] power: supply: test-power: use strscpy() to
 instead of? strncpy()

Hi,

On Fri, Dec 23, 2022 at 10:42:35AM +0800, yang.yang29@....com.cn wrote:
> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/test_power.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c
> index 5f510ddc946d..0d0a77584c5d 100644
> --- a/drivers/power/supply/test_power.c
> +++ b/drivers/power/supply/test_power.c
> @@ -306,8 +306,7 @@ static int map_get_value(struct battery_property_map *map, const char *key,
>  	char buf[MAX_KEYLENGTH];
>  	int cr;
> 
> -	strncpy(buf, key, MAX_KEYLENGTH);
> -	buf[MAX_KEYLENGTH-1] = '\0';
> +	strscpy(buf, key, MAX_KEYLENGTH);
> 
>  	cr = strnlen(buf, MAX_KEYLENGTH) - 1;
>  	if (cr < 0)
> -- 
> 2.15.2

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)