linux-kernel - Re: [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Feb 2023 13:14:23 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "linux-imx@....com" <linux-imx@....com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "victor.liu@....com" <victor.liu@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8
 aka quadmax module support

Hi Shawn

On Wed, 2023-02-01 at 04:01 +0100, Marcel Ziswiler wrote:

[snip]


> > > +/* Apalis UART1 */
> > > +&lpuart1 {
> > > +       dma-names = "","";
> > 
> > What is this for?
> 
> I guess that switches off DMA falling pack to PIO. Likely, there was an issue at one point in downstream. Let
> me re-test without it.

BTW: Upstream this indeed works just fine without this and I removed it in v6.

[snip]

> > > +&usbotg1 {
> > > +       adp-disable;
> > > +       ci-disable-lpm;
> > > +       hnp-disable;
> > > +       over-current-active-low;
> > > +       pinctrl-names = "default";
> > > +       pinctrl-0 = <&pinctrl_usbotg1>;
> > 
> > We generally want to put such generic properties before device specific
> > ones.
> 
> Okay.

Sorry, I missed the generally here. Let me re-work the device trees with this in mind adhering to hopefully all
the rules which apply and send a v7 ASAP.

> Thanks!

Thank you!

> > Shawn

Cheers

Marcel


[snip]