linux-kernel - Re: [PATCH] thermal: intel_powerclamp: Add dependency on CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gYvjT_=TADaFBHkYP7LGKE-SZVMYFFnCAj539JeJ3G5A@mail.gmail.com>
Date:   Fri, 3 Feb 2023 14:52:50 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     rafael@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] thermal: intel_powerclamp: Add dependency on CPU_IDLE

On Fri, Feb 3, 2023 at 1:35 PM Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
>
> Fix error:
>    WARNING: unmet direct dependencies detected for IDLE_INJECT
>      Depends on [n]: POWERCAP [=y] && CPU_IDLE [=n]
>      Selected by [y]:
>      - INTEL_POWERCLAMP [=y] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && X86 [=y] && CPU_SUP_INTEL [=y]
>
> Since IDLE_INJECT depends on CPU_IDLE, add that to INTEL_POWERCLAMP.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

I have folded this into the original patch that introduced the issue.

> ---
> This is for kernel
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
>
>  drivers/thermal/intel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> index b346a646fffb..b5808f92702d 100644
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -3,6 +3,7 @@ config INTEL_POWERCLAMP
>         tristate "Intel PowerClamp idle injection driver"
>         depends on X86
>         depends on CPU_SUP_INTEL
> +       depends on CPU_IDLE
>         select POWERCAP
>         select IDLE_INJECT
>         help
> --
> 2.39.1
>