linux-kernel - Re: [PATCH v2 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Feb 2023 16:36:09 +0100
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     arinc9.unal@...il.com, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>
CC:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        erkin.bozoglu@...ont.com, Sean Wang <sean.wang@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH v2 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2

Am 1. Februar 2023 19:56:55 MEZ schrieb arinc9.unal@...il.com:
>From: Arınç ÜNAL <arinc.unal@...nc9.com>
>
>Mux the MT7530 switch's phy0 to gmac5 which is wired to the SoC's gmac1.
>This achieves 2 Gbps total bandwidth to the CPU using the second RGMII.
>
>With this, the interface name to access phy0 changes from wan to eth1.
>
>Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>---
> arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>index dc9b4f99eb8b..64700253fd35 100644
>--- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>+++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
>@@ -182,6 +182,12 @@ fixed-link {
> 	};
> };
> 
>+&gmac1 {
>+	status = "okay";
>+	phy-mode = "rgmii";
>+	phy-handle = <&ethphy0>;
>+};
>+
> &eth {
> 	status = "okay";
> 
>@@ -189,6 +195,10 @@ mdio-bus {
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> 
>+		ethphy0: ethernet-phy@0 {
>+			reg = <0>;
>+		};
>+
> 		switch@1f {
> 			compatible = "mediatek,mt7530";
> 			reg = <0x1f>;
>@@ -200,11 +210,6 @@ ports {
> 				#address-cells = <1>;
> 				#size-cells = <0>;
> 
>-				port@0 {
>-					reg = <0>;
>-					label = "wan";
>-				};
>-
> 				port@1 {
> 					reg = <1>;
> 					label = "lan0";

Hi

I still see Problem with "renaming" the wan from users PoV. I got another way of using second gmac for wan some time ago using vlan-aware bridge (have not tested with recent kernel versions).

Maybe this works for you too? If yes imho it will be a better way.

https://github.com/frank-w/BPI-Router-Linux/commit/c92b648bac996b34dc75a4fff15d7fb429bfe74b

Have same for r64/mt7622 in my tree...

It should use eth1 for wan-traffic too but is full userspace configuration without breaking userspace for users not wanting it.
regards Frank