linux-kernel - Re: [PATCH] bcache: Fix __bch_btree_node_alloc to make the failure behavior consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJedcCxpj+MgiMTLXOgUFuK1aW9H7BXdB3nQnu8KH2LCKpPA_Q@mail.gmail.com>
Date:   Fri, 3 Feb 2023 10:08:13 +0800
From:   Zheng Hacker <hackerzheng666@...il.com>
To:     Eric Wheeler <bcache@...ts.ewheeler.net>
Cc:     Zheng Wang <zyytlz.wz@....com>, colyli@...e.de,
        kent.overstreet@...il.com, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org, alex000young@...il.com
Subject: Re: [PATCH] bcache: Fix __bch_btree_node_alloc to make the failure
 behavior consistent

Eric Wheeler <bcache@...ts.ewheeler.net> 于2023年2月3日周五 04:37写道：
>
> On Thu, 2 Feb 2023, Zheng Wang wrote:
>
> > In some specific situation, the return value of __bch_btree_node_alloc may
> > be NULL. This may lead to poential NULL pointer dereference in caller
> >  function like a calling chaion :
> >  btree_split->bch_btree_node_alloc->__bch_btree_node_alloc.
> >
> > Fix it by initialize return value in __bch_btree_node_alloc before return.
> >
> > Fixes: cafe56359144 ("bcache: A block layer cache")
> > Signed-off-by: Zheng Wang <zyytlz.wz@....com>
>
> Be sure to add `Cc: stable@...r.kernel.org`
>
> -Eric
>

Thanks for your kind reminding. Will do in the next patch.

Best regards,
Zheng Wang