linux-kernel - Re: Regarding checkpatch camelcase issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y94L+WNGGfvrg6Mg@debian.me>
Date:   Sat, 4 Feb 2023 14:40:41 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Guru Mehar Rachaputi <gurumeharrachaputi@...il.com>,
        Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: Regarding checkpatch camelcase issues

On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> Thanks for your support.
> 
> I wanted to confirm if each checkpatch encounter for camelcase issue should
> be fixed in a new patch?
> 
> For example: If the issue is with same variable, then multiple
> modifications can be made in one patch.
> 
>   -> above example is OK
> 
> 
> For example: If the issue is with multiple variables, then multiple
> modifications can be made in one patch.
> 
>   -> above example is NOT OK / NG
> 
> 
> Please confirm me if my understanding is correct?
> 

I guess you have generated a patch series, then check it through
checkpatch.

Indeed, if checkpatch complains at a particular patch, you need to do
interactive rebase. Make sure that rebase todo list contains "edit"
lines on commit you want to fix up. After that, fix these complaints.

When you're done, regenerate the patch series and make sure that there
are no checkpatch complains on it.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)