linux-kernel - Re: [PATCH] soc: sunxi: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e2c5a0db-aa25-496c-9a5e-4e996d908dc9@app.fastmail.com>
Date:   Sat, 04 Feb 2023 11:38:41 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Randy Dunlap" <rdunlap@...radead.org>,
        "Arnd Bergmann" <arnd@...nel.org>, "Chen-Yu Tsai" <wens@...e.org>,
        "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Samuel Holland" <samuel@...lland.org>,
        sparclinux <sparclinux@...r.kernel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: sunxi: select CONFIG_PM

On Sat, Feb 4, 2023, at 08:47, Randy Dunlap wrote:
> On 1/30/23 05:04, Arnd Bergmann wrote:
>
> Apparently sparc32 does not support PM (arch/sparc/Kconfig):
>
> if SPARC64
> source "kernel/power/Kconfig"
> endif
>
> so I think that SUN20I_PPU should also depend on !SPARC32.
> Does that make sense?

I would suggest working around this in arch/sparc/ instead
of every driver that uses 'select PM', perhaps something like

--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -283,7 +283,7 @@ config ARCH_FORCE_MAX_ORDER
          This config option is actually maximum order plus one. For example,
          a value of 13 means that the largest free memory block is 2^12 pages.
 
-if SPARC64
+if SPARC64 || COMPILE_TEST
 source "kernel/power/Kconfig"
 endif
 
The issue does not happen anywhere else, as it's fine if
kernel/power/Kconfig is not included at all. I'm also not too
worried about random sparc32 configs since it's pretty much impossible
to build a sparc32 allmodconfig or randconfig, with all the other
bugs that runs into.

     Arnd