linux-kernel - Re: [PATCH v1 net-next] net: mscc: ocelot: un-export unused regmap symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y96ZahikcXqYbOnf@MSI.localdomain>
Date:   Sat, 4 Feb 2023 09:44:10 -0800
From:   Colin Foster <colin.foster@...advantage.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        UNGLinuxDriver@...rochip.com,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH v1 net-next] net: mscc: ocelot: un-export unused regmap
 symbols

On Sat, Feb 04, 2023 at 03:34:39AM +0200, Vladimir Oltean wrote:
> On Fri, Feb 03, 2023 at 04:12:11PM -0800, Colin Foster wrote:
> > There are no external users of the vsc7514_*_regmap[] symbols. They were
> > exported in commit 32ecd22ba60b ("net: mscc: ocelot: split register
> > definitions to a separate file") with the intention of being used, but the
> > actual structure used in commit 2efaca411c96 ("net: mscc: ocelot: expose
> > vsc7514_regmap definition") ended up being all that was needed.
> > 
> > Bury these unnecessary symbols.
> > 
> > Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> > Suggested-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> 
> These can be unexported too:
> 
> extern const struct vcap_field vsc7514_vcap_es0_keys[];
> extern const struct vcap_field vsc7514_vcap_es0_actions[];
> extern const struct vcap_field vsc7514_vcap_is1_keys[];
> extern const struct vcap_field vsc7514_vcap_is1_actions[];
> extern const struct vcap_field vsc7514_vcap_is2_keys[];
> extern const struct vcap_field vsc7514_vcap_is2_actions[];

I was as positive as I could have been that I'd grepped (grept?) and saw
those used in Seville, Felix, and ocelot_ext yesterday. I'll fix this
up, and thanks for checking!

> 
> I guess we make exceptions for the 24 hour reposting rule when the patch
> has been reviewed?