linux-kernel - Re: [PATCH v2 0/4] Remove get_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiN3fPUDpiZBt+d_p1nncTnBEqmm_xqEa0soL-90Wdsrg@mail.gmail.com>
Date:   Sat, 4 Feb 2023 11:50:38 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Sumit Garg <sumit.garg@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
        op-tee@...ts.trustedfirmware.org, linux-mm@...ck.org,
        Jens Wiklander <jens.wiklander@...aro.org>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        John Hubbard <jhubbard@...dia.com>,
        Matthew Wilcox <willy@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH v2 0/4] Remove get_kernel_pages()

On Fri, Feb 3, 2023 at 8:06 PM Ira Weiny <ira.weiny@...el.com> wrote:
>
> This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses
> slip in later.

Ack. Please make it so.

That said...

I wasn't cc'd on all the patches, but checked them on the mailing
list, and that first is_kmap_addr() patch makes me a bit unhappy.

Right now that 'is_kmap_addr()' is only used for user copy addresses,
for debugging purposes, and I'm not exactly thrilled about extending
it this way.

I get the feeling that we should just have a name for that "kmap _or_
kmap_local" range instead of making it two ranges.

But admittedly I can't come up with anything better, and it looks like
different architectures may do different things.  I just don't like
it.

                Linus