linux-kernel - Re: [PATCH] staging: vt6655: Add braces to macro parameter 'iobase'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y97006iBeoRV7I8b@combine-ThinkPad-S1-Yoga>
Date:   Sun, 5 Feb 2023 01:14:11 +0100
From:   Guru Mehar Rachaputi <gurumeharrachaputi@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: Add braces to macro parameter 'iobase'

On Sat, Feb 04, 2023 at 08:55:09AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Feb 04, 2023 at 04:50:41AM +0100, Guru Mehar Rachaputi wrote:
> > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> > as '(iobase)' to avoid precedence issues.
> > 
> > Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@...il.com>
> > ---
> >  drivers/staging/vt6655/mac.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index acf931c3f5fd..a33af2852227 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -537,9 +537,9 @@
> >  
> >  /*---------------------  Export Macros ------------------------------*/
> >  
> > -#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
> > +#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)
> 
> This change really doesn't make much sense, right?  How about turning
> these into an inline function instead?  That would be the correct thing
> to do overall, right?
> 
> thanks,
> 
> greg k-h

Thanks for the reply and advice.
I have modified accordingly and sending in as a v2 patch for the above.

--
Thanks & Regards,
Guru