linux-kernel - Re: [PATCH] vdpa/mlx5: Directly assign memory key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14bbde0d-6f4c-9615-0fff-ca68e81c073c@nvidia.com>
Date:   Sun, 5 Feb 2023 09:26:20 +0200
From:   Eli Cohen <elic@...dia.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     jasowang@...hat.com, si-wei.liu@...cle.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Directly assign memory key


On 02/02/2023 19:32, Michael S. Tsirkin wrote:
> On Thu, Feb 02, 2023 at 02:57:18PM +0200, Eli Cohen wrote:
>> When creating a memory key, the key value should be assigned to the
>> passed pointer and not or'ed to.
>>
>> This fix has is required but had no real impact so far.
> I don't get what this sentence says. Both grammar and general meaning
> elude me.

And I can't blame you for that.

Re-sending...

>
>> Fixes: 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation")
>> Signed-off-by: Eli Cohen <elic@...dia.com>
>> ---
>>   drivers/vdpa/mlx5/core/resources.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c
>> index 9800f9bec225..45ad41287a31 100644
>> --- a/drivers/vdpa/mlx5/core/resources.c
>> +++ b/drivers/vdpa/mlx5/core/resources.c
>> @@ -213,7 +213,7 @@ int mlx5_vdpa_create_mkey(struct mlx5_vdpa_dev *mvdev, u32 *mkey, u32 *in,
>>   		return err;
>>   
>>   	mkey_index = MLX5_GET(create_mkey_out, lout, mkey_index);
>> -	*mkey |= mlx5_idx_to_mkey(mkey_index);
>> +	*mkey = mlx5_idx_to_mkey(mkey_index);
>>   	return 0;
>>   }
>>   
>> -- 
>> 2.38.1