linux-kernel - [irqchip: irq/irqchip-next] irqchip/irq-mvebu-gicp: Fix refcount leak in mvebu_gicp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167559659275.4906.14558130983699966637.tip-bot2@tip-bot2>
Date:   Sun, 05 Feb 2023 11:29:52 -0000
From:   "irqchip-bot for Miaoqian Lin" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Miaoqian Lin <linmq006@...il.com>, Marc Zyngier <maz@...nel.org>,
        tglx@...utronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/irq-mvebu-gicp: Fix refcount leak
 in mvebu_gicp_probe

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     9419e700021a393f67be36abd0c4f3acc6139041
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9419e700021a393f67be36abd0c4f3acc6139041
Author:        Miaoqian Lin <linmq006@...il.com>
AuthorDate:    Mon, 02 Jan 2023 12:42:08 +04:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Sun, 05 Feb 2023 11:11:24 

irqchip/irq-mvebu-gicp: Fix refcount leak in mvebu_gicp_probe

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/20230102084208.3951758-1-linmq006@gmail.com
---
 drivers/irqchip/irq-mvebu-gicp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
index fe88a78..c43a345 100644
--- a/drivers/irqchip/irq-mvebu-gicp.c
+++ b/drivers/irqchip/irq-mvebu-gicp.c
@@ -221,6 +221,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
 	}
 
 	parent_domain = irq_find_host(irq_parent_dn);
+	of_node_put(irq_parent_dn);
 	if (!parent_domain) {
 		dev_err(&pdev->dev, "failed to find parent IRQ domain\n");
 		return -ENODEV;