| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAhSdy1ABfu_=-9NB7C1Pb9NzBpg7D+GA-W3XGLFRO2w=d6bkw@mail.gmail.com>
Date: Mon, 6 Feb 2023 22:40:12 +0530
From: Anup Patel <anup@...infault.org>
To: Atish Patra <atishp@...osinc.com>
Cc: linux-kernel@...r.kernel.org, Albert Ou <aou@...s.berkeley.edu>,
Andrew Jones <ajones@...tanamicro.com>,
Atish Patra <atishp@...shpatra.org>,
Guo Ren <guoren@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
kvm-riscv@...ts.infradead.org, kvm@...r.kernel.org,
linux-riscv@...ts.infradead.org,
Mark Rutland <mark.rutland@....com>,
Palmer Dabbelt <palmer@...belt.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Will Deacon <will@...nel.org>
Subject: Re: [PATCH v5 00/14] KVM perf support
On Sun, Feb 5, 2023 at 6:45 AM Atish Patra <atishp@...osinc.com> wrote:
>
> This series extends perf support for KVM. The KVM implementation relies
> on the SBI PMU extension and trap n emulation of hpmcounter CSRs.
> The KVM implementation exposes the virtual counters to the guest and internally
> manage the counters using kernel perf counters.
>
> This series doesn't support the counter overflow as the Sscofpmf extension
> doesn't allow trap & emulation mechanism of scountovf CSR yet. The required
> changes to allow that are being under discussions. Supporting overflow interrupt
> also requires AIA interrupt filtering support.
>
> 1. PATCH 1-5 are generic KVM/PMU driver improvements.
> 2. PATCH 9 disables hpmcounter for now. It will be enabled to maintain ABI
> requirement once the ONE reg interface is settled.
>
> perf stat works in kvm guests with this series.
>
> Here is example of running perf stat in a guest running in KVM.
>
> ===========================================================================
> / # /host/apps/perf stat -e instructions -e cycles -e r8000000000000005 \
> > -e r8000000000000006 -e r8000000000000007 -e r8000000000000008 \
> > -e r800000000000000a perf bench sched messaging -g 10 -l 10
>
> # Running 'sched/messaging' benchmark:
> # 20 sender and receiver processes per group
> # 10 groups == 400 processes run
>
> Total time: 7.769 [sec]
>
> Performance counter stats for 'perf bench sched messaging -g 10 -l 10':
>
> 73556259604 cycles
> 73387266056 instructions # 1.00 insn per cycle
> 0 dTLB-store-misses
> 0 iTLB-load-misses
> 0 r8000000000000005
> 2595 r8000000000000006
> 2272 r8000000000000007
> 10 r8000000000000008
> 0 r800000000000000a
>
> 12.173720400 seconds time elapsed
>
> 1.002716000 seconds user
> 21.931047000 seconds sys
>
>
> Note: The SBI_PMU_FW_SET_TIMER (eventid : r8000000000000005) is zero
> as kvm guest supports sstc now.
>
> This series can be found here as well.
> https://github.com/atishp04/linux/tree/kvm_perf_v5
>
> TODO:
> 1. Add sscofpmf support.
> 2. Add One reg interface for the following operations:
> 1. Enable/Disable PMU (should it at VM level rather than vcpu ?)
> 2. Number of hpmcounter and width of the counters
> 3. Init PMU
> 4. Allow guest user to access cycle & instret without trapping
> 3. Move counter mask to a bitmask instead of unsigned long so that it can work
> for RV32 systems where number of total counters are more than 32.
> This will also accomodate future systems which may define maximum counters
> to be more than 64.
>
> Changes from v4->v5:
> 1. Few checkpatch --strict error fixes.
> 2. Some other minor nit comment addressed.
> 3. Fixed an issue around counter indexing.
>
> Changes from v3->v4:
> 1. Addressed all the comments on v3.
> 2. Modified the vcpu_pmu_init to void return type.
> 3. Redirect illegal instruction trap to guest for invalid hpmcounter access
> instead of exiting to the userpsace.
> 4. Got rid of unecessary error messages.
>
> Changes v2->v3:
> 1. Changed the exported functions to GPL only export.
> 2. Addressed all the nit comments on v2.
> 3. Split non-kvm related changes into separate patches.
> 4. Reorgainze the PATCH 11 and 10 based on Drew's suggestions.
>
> Changes from v1->v2:
> 1. Addressed comments from Andrew.
> 2. Removed kvpmu sanity check.
> 3. Added a kvm pmu init flag and the sanity check to probe function.
> 4. Improved the linux vs sbi error code handling.
>
>
> Atish Patra (14):
> perf: RISC-V: Define helper functions expose hpm counter width and
> count
> perf: RISC-V: Improve privilege mode filtering for perf
> RISC-V: Improve SBI PMU extension related definitions
> RISC-V: KVM: Define a probe function for SBI extension data structures
> RISC-V: KVM: Return correct code for hsm stop function
> RISC-V: KVM: Modify SBI extension handler to return SBI error code
> RISC-V: KVM: Add skeleton support for perf
> RISC-V: KVM: Add SBI PMU extension support
> RISC-V: KVM: Make PMU functionality depend on Sscofpmf
> RISC-V: KVM: Disable all hpmcounter access for VS/VU mode
> RISC-V: KVM: Implement trap & emulate for hpmcounters
> RISC-V: KVM: Implement perf support without sampling
> RISC-V: KVM: Support firmware events
> RISC-V: KVM: Increment firmware pmu events
I have queued PATCH1-to-PATCH6 for Linux-6.3
Please send v6 based on riscv_kvm_queue.
Regards,
Anup
>
> arch/riscv/include/asm/kvm_host.h | 4 +
> arch/riscv/include/asm/kvm_vcpu_pmu.h | 111 +++++
> arch/riscv/include/asm/kvm_vcpu_sbi.h | 13 +-
> arch/riscv/include/asm/sbi.h | 7 +-
> arch/riscv/kvm/Makefile | 1 +
> arch/riscv/kvm/main.c | 3 +-
> arch/riscv/kvm/tlb.c | 4 +
> arch/riscv/kvm/vcpu.c | 7 +
> arch/riscv/kvm/vcpu_insn.c | 4 +-
> arch/riscv/kvm/vcpu_pmu.c | 627 ++++++++++++++++++++++++++
> arch/riscv/kvm/vcpu_sbi.c | 72 ++-
> arch/riscv/kvm/vcpu_sbi_base.c | 27 +-
> arch/riscv/kvm/vcpu_sbi_hsm.c | 28 +-
> arch/riscv/kvm/vcpu_sbi_pmu.c | 87 ++++
> arch/riscv/kvm/vcpu_sbi_replace.c | 50 +-
> arch/riscv/kvm/vcpu_sbi_v01.c | 17 +-
> drivers/perf/riscv_pmu_sbi.c | 64 ++-
> include/linux/perf/riscv_pmu.h | 5 +
> 18 files changed, 1021 insertions(+), 110 deletions(-)
> create mode 100644 arch/riscv/include/asm/kvm_vcpu_pmu.h
> create mode 100644 arch/riscv/kvm/vcpu_pmu.c
> create mode 100644 arch/riscv/kvm/vcpu_sbi_pmu.c
>
> --
> 2.25.1
>
Powered by blists - more mailing lists