linux-kernel - Re: [PATCH] [RESEND v4] printf: fix errname.c list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <096fa00d-8625-172c-74ba-134ddb1395ef@rasmusvillemoes.dk>
Date:   Mon, 6 Feb 2023 20:59:59 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Arnd Bergmann <arnd@...nel.org>, Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Ogness <john.ogness@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND v4] printf: fix errname.c list

On 06/02/2023 20.40, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> On most architectures, gcc -Wextra warns about the list of error
> numbers containing both EDEADLK and EDEADLOCK:
> 

[...]

> To ensure these are correct, add static_assert lines that verify
> all the remaining aliases are in fact identical to the canonical
> name.
> 
> Fixes: 57f5677e535b ("printf: add support for printing symbolic error names")
> Cc: Petr Mladek <pmladek@...e.com>
> Suggested-by: Rasmus Villemoes <linux@...musvillemoes.dk>

You may also add Acked-by: me.

> Acked-by: Uwe Kleine-König <uwe@...ine-koenig.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Link: https://lore.kernel.org/all/20210514213456.745039-1-arnd@kernel.org/
> Link: https://lore.kernel.org/all/20210927123409.1109737-1-arnd@kernel.org/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I sent this a few times, but it never made it in so far. The warning
> still shows up when enabling extra warnings, and this is an actual bug.

Petr, please pick this up.

Rasmus