[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53bc0584-51eb-8bb7-de48-ca07fccafc19@gmail.com>
Date: Mon, 6 Feb 2023 23:04:54 +0300
From: Sergei Shtylyov <sergei.shtylyov@...il.com>
To: Alan Stern <stern@...land.harvard.edu>,
Karina Yankevich <k.yankevich@....ru>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] usb: storage: sddr55: avoid integer overflow
Hello!
On 2/3/23 11:48 PM, Alan Stern wrote:
[...]
>> We're possibly losing information by shifting an int.
>> Fix it by adding the necessary cast.
>
> Nonsense. The card's _total_ capacity is no larger than 128 MB, so a
> page address can't possibly overflow an int.
Then the 'address' variables shouldn't be declared *unsigned long*, right?
That should fix the SVACE's report as well. Would you accept such a patch?
> Alan Stern
[...]
MBR, Sergey
Powered by blists - more mailing lists