linux-kernel - Re: [PATCH v2 4/4] locktorture: With nested locks, occasionally skip main lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCrG5zRZCFdz_k5fnsc8vqNbEu_9++qvR34FW_DXJcpVNA@mail.gmail.com>
Date:   Mon, 6 Feb 2023 12:37:56 -0800
From:   John Stultz <jstultz@...gle.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Josh Triplett <josh@...htriplett.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>
Subject: Re: [PATCH v2 4/4] locktorture: With nested locks, occasionally skip
 main lock

On Sun, Feb 5, 2023 at 11:33 AM Davidlohr Bueso <dave@...olabs.net> wrote:
> On Fri, 03 Feb 2023, John Stultz wrote:
>
> >@@ -754,21 +755,28 @@ static int lock_torture_writer(void *arg)
> >                       schedule_timeout_uninterruptible(1);
> >
> >               lockset_mask = torture_random(&rand);
> >+              skip_main_lock = nlocks && !(torture_random(&rand) % 100);
>
> For the sake of future readers of locktorture.c, this deserves a comment
> as to why we wanna skip the main lock (copy/paste from the changelog).

Good point! I'll send this update out soon.

Thanks again for the review and feedback!
-john