linux-kernel - Re: [PATCH] soc: qcom: pmic_glink: remove redundant calculation of svid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon,  6 Feb 2023 14:30:39 -0800
From:   Bjorn Andersson <andersson@...nel.org>
To:     agross@...nel.org, Tom Rix <trix@...hat.com>,
        konrad.dybcio@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink: remove redundant calculation of svid

On Mon, 6 Feb 2023 05:58:31 -0800, Tom Rix wrote:
> gcc with W=1 reports
> drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable]
>   223 |         u16 svid;
> 
> From reviewing the code, the setting of alt_port->svid does the same calculation.
> Both are not needed.  For debuggablity, keep the setting of local svid.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pmic_glink: remove redundant calculation of svid
      commit: dcb4e7a57cbe8d85e4927f517ae28aab17596419

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>