linux-kernel - [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230206234344.2433950-2-mcgrof@kernel.org>
Date:   Mon,  6 Feb 2023 15:43:43 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     shuah@...nel.org, linux-kselftest@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, tiwai@...e.de, tianfei.zhang@...el.com,
        russell.h.weight@...el.com, keescook@...omium.org,
        tweek@...gle.com, a.manzanares@...sung.com, dave@...olabs.net,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165

The default sefltests timeout is 45 seconds. If you run the kmod
selftests on your own with say:

./tools/testings/selftests/kmod.sh

Then the default timeout won't be in effect.

I've never ran kmod selftests using the generic make wrapper
(./tools/testing/selftests/run_kselftest.sh -s) util now
that I have support for it on kdevops [0]. And with that the
test is limitted to the default timeout which we quickly run
into. Bump this up to what I see is required on 8GiB / 8 vcpu
libvirt q35 guest as can be easily created now with kdevops.

To run selftests with kdevops:

make menuconfig # enable dedicated selftests and kmod test
make
make bringup
make linux
make selftests-kmod

This ends up taking about 280 seconds now, give or take add
50 seconds more more and we end up with 350. Document the
rationale.

[0] https://github.com/linux-kdevops/kdevops
Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
---
 tools/testing/selftests/kmod/settings | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/testing/selftests/kmod/settings

diff --git a/tools/testing/selftests/kmod/settings b/tools/testing/selftests/kmod/settings
new file mode 100644
index 000000000000..6fca0f1a4594
--- /dev/null
+++ b/tools/testing/selftests/kmod/settings
@@ -0,0 +1,4 @@
+# measured from a manual run:
+# time ./tools/testing/selftests/kmod/kmod.sh
+# Then add ~50 seconds more gracetime.
+timeout=350
-- 
2.39.1