linux-kernel - Re: [PATCH] ASoC: codecs: es8326: Fix DTS properties reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96c99731-a5e9-778d-24f5-cb42a5c2d840@huawei.com>
Date:   Mon, 6 Feb 2023 16:42:34 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Alexey Firago <a.firago@...ro.com>, <linux-kernel@...r.kernel.org>
CC:     <alsa-devel@...a-project.org>, <zhuning0077@...il.com>,
        <yangxiaohua@...rest-semi.com>, <broonie@...nel.org>,
        <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: codecs: es8326: Fix DTS properties reading

Hi,

On 2023/2/5 3:51, Alexey Firago wrote:
> Seems like properties parsing and reading was copy-pasted,
> so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
> the es8326->jack_pol variable. This might lead to wrong settings
> being saved into the reg 57 (ES8326_HP_DET).
>
> Fix this by using proper variables while reading properties.
>
> Signed-off-by: Alexey Firago <a.firago@...ro.com>

Fix tag is needed, it should be 5c439937775d ("ASoC: codecs: add support 
for ES8326")

Reviewed-by: Yang Yingliang <yangyingliang@...wei.com