linux-kernel - RE: [PATCH v3 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB59587A0639FE44245A68312B9BDA9@PH7PR11MB5958.namprd11.prod.outlook.com>
Date:   Mon, 6 Feb 2023 09:20:51 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <gregkh@...uxfoundation.org>, <Kumaravel.Thiagarajan@...rochip.com>
CC:     <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <lkp@...el.com>
Subject: RE: [PATCH v3 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch

> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, January 20, 2023 4:26 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>
> > +             dev_err(&priv->pdev->dev,
> > +                     "EPC_Timeout, EEPROM is unresponsive: %x\n",
> > + data);
> 
> Can this spam the kernel logs?  If so, please rate limit it.

This print will only come once at max and will not spam logs.

> > +     delay = msecs_to_jiffies(OTP_RW_TIMEOUT_MILLISECONDS);
> > +     j0 = jiffies;
> > +     j1 = j0 + delay;
> 
> Are you sure this math works out?  Please use the jiffies math functions
> instead so you can handle wrapping properly.

You suggest using any existing APIs to add jiffies to handle wrapping? I am not able 
to find any such API. Can you please point out API name. 

Thanks,
Tharun Kumar P