linux-kernel - Re: [PATCH] HID: quirks: Add quirk for Logitech G923 Xbox steering wheel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2023 10:51:39 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Walt Holman <waltholman09@...il.com>
Cc:     linux-input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Mattijs Korpershoek <mkorpershoek@...libre.com>
Subject: Re: [PATCH] HID: quirks: Add quirk for Logitech G923 Xbox steering
 wheel

Hi Walt,

On Jan 27 2023, Walt Holman wrote:
> On 1/27/23 16:03, Walt Holman wrote:
> > Hello,
> > 
> > This patch adds support for the Logitech G923 Xbox edition steering
> > wheel.
> > 
> > -Walt
> > 
> > diff -uprN linux-master-source/drivers/hid/hid-ids.h linux-master-target/drivers/hid/hid-ids.h
> > --- linux-master-source/drivers/hid/hid-ids.h    2023-01-27 15:18:14.000000000 -0600
> > +++ linux-master-target/drivers/hid/hid-ids.h    2023-01-27 15:50:24.077639994 -0600
> > @@ -819,6 +819,7 @@
> >   #define USB_DEVICE_ID_LOGITECH_G510_USB_AUDIO    0xc22e
> >   #define USB_DEVICE_ID_LOGITECH_G29_WHEEL    0xc24f
> >   #define USB_DEVICE_ID_LOGITECH_G920_WHEEL    0xc262
> > +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL    0xc26e
> >   #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D    0xc283
> >   #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO    0xc286
> >   #define USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940    0xc287
> > diff -uprN linux-master-source/drivers/hid/hid-logitech-hidpp.c linux-master-target/drivers/hid/hid-logitech-hidpp.c
> > --- linux-master-source/drivers/hid/hid-logitech-hidpp.c    2023-01-27 15:18:14.000000000 -0600
> > +++ linux-master-target/drivers/hid/hid-logitech-hidpp.c    2023-01-27 15:50:24.077639994 -0600
> > @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_
> >       { /* Logitech G920 Wheel over USB */
> >         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
> >           .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
> > +    { /* Logitech G923 Wheel (Xbox version) over USB */
> > +      HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL),
> > +        .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
> >       { /* Logitech G Pro Gaming Mouse over USB */
> >         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
> > 
> Signed off by: Walt Holman (waltholman09@...il.com)
> 

Thanks a lot for your submission. I wanted to quickly include it in the
kernel, but it seems that the patch is not following the standards:
- "git am" on your patch refuses to take it, saying it is corrupted
  (please use "git format-patch" to generate the proper patch format)
- your patch doesn't have a proper commit description:
  please add a description like "adds support for the Logitech G923 Xbox
  edition steering wheel in hid-logitech-hidpp. We get the same level
  of features than the regular G920". Or anything else as long as we get
  a sensible commit description.

As a general rule of thumb, please follow the doc at [1] to submit your
patches.

Cheers,
Benjamin

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst