linux-kernel - Re: [PATCH v12 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+DxHsudEDlMEoH6@smile.fi.intel.com>
Date:   Mon, 6 Feb 2023 14:22:54 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        ilpo.jarvinen@...ux.intel.com, macro@...am.me.uk, lukas@...ner.de,
        cang1@...e.co.uk, matthew.gerlach@...ux.intel.com, deller@....de,
        phil.edworthy@...esas.com, geert+renesas@...der.be,
        marpagan@...hat.com, u.kleine-koenig@...gutronix.de,
        etremblay@...tech-controls.com, wander@...hat.com,
        Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>
Subject: Re: [PATCH v12 tty-next 1/4] serial: 8250_pci: Add
 serial8250_pci_setup_port definition in 8250_pcilib.c

On Mon, Feb 06, 2023 at 10:56:10PM +0530, Kumaravel Thiagarajan wrote:
> Move implementation of setup_port func() to serial8250_pci_setup_port.

...

>  #include "8250.h"
> +#include "8250_pcilib.h"

...

> +#include <linux/ioport.h>
> +#include <linux/pci.h>
> +#include <linux/types.h>
> +#include "8250_pcilib.h"
> +
> +#include "8250.h"

I would expect consistency as per above.

-- 
With Best Regards,
Andy Shevchenko