linux-kernel - Re: [RESEND PATCH 30/37] nvmem: core: fix nvmem_layout_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+D1FN0rXwCPJtBz@kroah.com>
Date:   Mon, 6 Feb 2023 13:39:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        Michael Walle <michael@...le.cc>
Subject: Re: [RESEND PATCH 30/37] nvmem: core: fix
 nvmem_layout_get_match_data()

On Mon, Feb 06, 2023 at 12:08:09PM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 06/02/2023 12:04, Greg KH wrote:
> > On Mon, Feb 06, 2023 at 10:27:52AM +0000, Srinivas Kandagatla wrote:
> > > From: Rafał Miłecki <rafal@...ecki.pl>
> > > 
> > > This function was trying to match wrong OF node (parent device's)
> > > against an of_match_table. It was always returning NULL.
> > > 
> > > Make it match layout's OF node against layout's of_match_table.
> > > 
> > > Note: __maybe_unused is needed to avoid:
> > > warning: variable 'layout_np' set but not used [-Wunused-but-set-variable]
> > > (of_match_node() is no-op without CONFIG_OF).
> > > 
> > > Fixes: 61a093b4a0e0 ("nvmem: core: introduce NVMEM layouts")
> > 
> > Nit, how can you have a git commit id if you are sending me patches to
> > be applied to my tree?
> > 
> How should I deal with this situation?
> I apply patches to nvmem-next tree and developers fix issues on top of it.
> On the other hand I send patches as list to you to go via char-misc, so the
> fixes tag is really not relevant to char-misc.
> 
> Should I drop those fixes tag before sending it out?

Probably as the git commit id makes no sense anymore.

thanks,

greg k-h