linux-kernel - Re: [GIT PULL] TTY/Serial driver fixes for 6.2-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d11640a-9adf-b1d5-b21a-8cfd5275aa5c@oracle.com>
Date:   Mon, 6 Feb 2023 08:05:28 -0500
From:   George Kennedy <george.kennedy@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Jiri Slaby <jslaby@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [GIT PULL] TTY/Serial driver fixes for 6.2-rc7



On 2/6/2023 2:38 AM, Greg KH wrote:
> On Sun, Feb 05, 2023 at 12:17:05PM -0800, Linus Torvalds wrote:
>> On Sun, Feb 5, 2023 at 3:53 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>>> George Kennedy (1):
>>>        vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF
>> Hmm.
>>
>> I think the "goto unlock_out" should be a "break". A partial read
>> should return the partial success, not an error.
>>
>> That situation didn't exist when the check was outside the loop, but does now.
>>
>> Now, I don't think this matters for any sane situation, but since I
>> looked at this patch I thought I'd mention it.
> Fair enough, George, can you send a follow-on patch to fix this up?
Hi Greg,

Will send a follow-on patch.

Thanks,
George
>
> thanks,
>
> greg k-h