linux-kernel - Re: [PATCH] ASoC: codecs: aw88395: initialize cur_scene

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167569419441.112200.7737939979688207071.b4-ty@kernel.org>
Date:   Mon, 06 Feb 2023 14:36:34 +0000
From:   Mark Brown <broonie@...nel.org>
To:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        liweilei@...nic.com, colin.i.king@...il.com,
        wangweidong.a@...nic.com, zhaolei@...nic.com,
        Tom Rix <trix@...hat.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: codecs: aw88395: initialize cur_scene_id to 0

On Sat, 04 Feb 2023 17:57:33 -0800, Tom Rix wrote:
> cppcheck reports
> sound/soc/codecs/aw88395/aw88395_lib.c:789:6: error: Uninitialized variable: cur_scene_id [uninitvar]
>  if (cur_scene_id == 0) {
>      ^
> 
> Passing a garbage value to aw_dev_parse_data_by_sec_type_v1() will cause a crash
> when the value is used as an array index.  This check assumes cur_scene_id is
> initialized to 0, so initialize it to 0.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: aw88395: initialize cur_scene_id to 0
      commit: 983272a2a223de59dbb4cb189aa4d02d7156d209

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark