linux-kernel - Re: [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdbd3492-6ad6-2dba-70a9-f170e29dc70b@nvidia.com>
Date:   Mon, 6 Feb 2023 15:26:17 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Tom Rix <trix@...hat.com>, "hare@...e.de" <hare@...e.de>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to
 static

On 2/6/23 06:57, Tom Rix wrote:
> smatch reports
> drivers/nvme/host/auth.c:48:25: warning: symbol 'nvme_auth_wq' was not declared. Should it be static?
> 
> nvme_auth_wq is only used in auth.c, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/nvme/host/auth.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index b57630d1d3b8..bdb97496ba2d 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -45,7 +45,7 @@ struct nvme_dhchap_queue_context {
>   	int sess_key_len;
>   };
>   
> -struct workqueue_struct *nvme_auth_wq;
> +static struct workqueue_struct *nvme_auth_wq;
>   
>   #define nvme_auth_flags_from_qid(qid) \
>   	(qid == 0) ? 0 : BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck