[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+JtQ26xEU70KxkC@hovoldconsulting.com>
Date: Tue, 7 Feb 2023 16:24:51 +0100
From: Johan Hovold <johan@...nel.org>
To: David Collins <quic_collinsd@...cinc.com>
Cc: Johan Hovold <johan+linaro@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Bjorn Andersson <andersson@...nel.org>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Maximilian Luz <luzmaximilian@...il.com>,
linux-arm-msm@...r.kernel.org, linux-rtc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 16/22] dt-bindings: rtc: qcom-pm8xxx: add nvmem-cell
offset
On Mon, Feb 06, 2023 at 07:16:37PM -0800, David Collins wrote:
> On 2/2/23 07:54, Johan Hovold wrote:
> > On many Qualcomm platforms the PMIC RTC control and time registers are
> > read-only so that the RTC time can not be updated. Instead an offset
>
> s/can not/cannot/
As far as I can tell, 'can not' is still correct even if it's less
commonly used this way compared to 'cannot'.
> > needs be stored in some machine-specific non-volatile memory, which a
> > driver can take into account.
> >
> > Add an 'offset' nvmem cell which can be used to store a 32-bit offset
> > from the Unix epoch so that the RTC time can be updated on such
> > platforms.
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > ---
> > .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> Assuming that the minor commit text comment above is addressed:
I'm definitely not resending because of this, but I'll keep it in mind
for future patches. Thanks.
> Reviewed-by: David Collins <quic_collinsd@...cinc.com>
Johan
Powered by blists - more mailing lists