linux-kernel - Re: [PATCH] arm64: dts: Add support for Unisoc's UMS512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfSe-v3VW_sE4FwjURoOapMXrGavOK0hzeU-84-U_6xfhYbQQ@mail.gmail.com>
Date:   Tue, 7 Feb 2023 10:19:48 +0800
From:   Chunyan Zhang <zhang.lyra@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Chunyan Zhang <chunyan.zhang@...soc.com>,
        Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, soc@...nel.org,
        devicetree@...r.kernel.org,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Orson Zhai <orsonzhai@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: Add support for Unisoc's UMS512

On Thu, 19 Jan 2023 at 19:40, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 18/01/2023 09:40, Chunyan Zhang wrote:
> > Add basic support for Unisoc's UMS512, with this patch,
> > the board ums512-1h10 can run into console.
> >

[snip]

> > +             ap-apb {
>
> Non-unit-address nodes cannot be mixed with unit address ones. Something
> is wrong here.

To make sure I understand correctly, did you mean non-unit-address
nodes shouldn't be the parent of unit-address nodes?

Does that mean the bus node should have a unique base address like:
        ap-apb@...00000 {
        ...

Thanks,
Chunyan

>
> > +                     compatible = "simple-bus";
> > +                     #address-cells = <2>;
> > +                     #size-cells = <2>;
> > +                     ranges;
> > +
> > +                     sdio0: sdio@...00000 {
> > +                             compatible = "sprd,sdhci-r11";
> > +                             reg = <0 0x71100000 0 0x1000>;
> > +                             interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clock-names = "sdio", "enable";
> > +                             clocks = <&ap_clk CLK_SDIO0_2X>,
> > +                                      <&apapb_gate CLK_SDIO0_EB>;
> > +                             assigned-clocks = <&ap_clk CLK_SDIO0_2X>;
> > +                             assigned-clock-parents = <&pll1 CLK_RPLL>;
> > +                             status = "disabled";
> > +                     };