linux-kernel - Re: [PATCH] scripts/gdb: fix 'lx-current' for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acb79609-ca85-dab4-c4f8-6f37ec279d13@siemens.com>
Date:   Tue, 7 Feb 2023 17:32:35 +0100
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Jeff Xie <xiehuan09@...il.com>, kbingham@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/gdb: fix 'lx-current' for x86

On 07.02.23 16:48, Jeff Xie wrote:
> Andrew was added.
> 
> Hi Andrew,
> 
> I found the patches for the ./scripts/gdb/*  were merged by you before,
> but the "./scripts/get_maintainer.pl ./scripts/gdb/linux/cpus.py"
> can't find your name,  so added you.
> 

Yes, Andrew is merging scripts/gdb stuff.

> Can you review this patch ;-)
> 
> On Sat, Feb 4, 2023 at 5:02 PM Jeff Xie <xiehuan09@...il.com> wrote:
>>
>> When printing the name of the current process, it will report an error:
>> (gdb) p $lx_current().comm
>> Python Exception <class 'gdb.error'> No symbol "current_task" in current context.:
>> Error occurred in Python: No symbol "current_task" in current context.
>>
>> Because the commit <e57ef2ed97c1> ("x86: Put hot per CPU variables into a struct")
>> changed it.
>>
>> Signed-off-by: Jeff Xie <xiehuan09@...il.com>
>> ---
>>  scripts/gdb/linux/cpus.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py
>> index 15fc4626d236..9ee99f9fae8d 100644
>> --- a/scripts/gdb/linux/cpus.py
>> +++ b/scripts/gdb/linux/cpus.py
>> @@ -163,7 +163,7 @@ def get_current_task(cpu):
>>      task_ptr_type = task_type.get_type().pointer()
>>
>>      if utils.is_target_arch("x86"):
>> -         var_ptr = gdb.parse_and_eval("&current_task")
>> +         var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
>>           return per_cpu(var_ptr, cpu).dereference()
>>      elif utils.is_target_arch("aarch64"):
>>           current_task_addr = gdb.parse_and_eval("$SP_EL0")
>> --
>> 2.25.1
>>
> 

FWIW:

Reviewed-by: Jan Kiszka <jan.kiszka@...mens.com>

Should go into 6.2 if possible.

Thanks
Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux