linux-kernel - Re: [PATCH v2] proc: remove mark_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+KVoI/GVaoEFQxa@p183>
Date:   Tue, 7 Feb 2023 21:17:04 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Chao Yu <chao@...nel.org>
Cc:     akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] proc: remove mark_inode_dirty() in .setattr()

On Tue, Jan 31, 2023 at 11:08:40PM +0800, Chao Yu wrote:
> procfs' .setattr() has updated i_uid, i_gid and i_mode into proc
> dirent, we don't need to call mark_inode_dirty() for delayed
> update, remove it.

> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -699,7 +699,6 @@ int proc_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
>  		return error;
>  
>  	setattr_copy(&init_user_ns, inode, attr);
> -	mark_inode_dirty(inode);

Reviewed-by: Alexey Dobriyan <adobriyan@...il.com>