linux-kernel - RE: [PATCH 3/3] x86/platform/uv: Make kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2023 19:48:13 +0000
From:   "Ernst, Justin" <justin.ernst@....com>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        "Divya Bharathi" <divya.bharathi@...l.com>,
        Prasanth Ksr <prasanth.ksr@...l.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        "Mark Pearson" <markpearson@...ovo.com>
CC:     "Dell.Client.Kernel@...l.com" <Dell.Client.Kernel@...l.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] x86/platform/uv: Make kobj_type structure constant

> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Looks good. Thanks for the patch!

Reviewed-by: Justin Ernst <justin.ernst@....com>

> ---
>  drivers/platform/x86/uv_sysfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 73fc38ee7430..38d1b692d3c0 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -203,7 +203,7 @@ static const struct sysfs_ops hub_sysfs_ops = {
>  	.show = hub_type_show,
>  };
> 
> -static struct kobj_type hub_attr_type = {
> +static const struct kobj_type hub_attr_type = {
>  	.release	= hub_release,
>  	.sysfs_ops	= &hub_sysfs_ops,
>  	.default_groups	= uv_hub_groups,
> @@ -356,7 +356,7 @@ static const struct sysfs_ops uv_port_sysfs_ops = {
>  	.show = uv_port_type_show,
>  };
> 
> -static struct kobj_type uv_port_attr_type = {
> +static const struct kobj_type uv_port_attr_type = {
>  	.release	= uv_port_release,
>  	.sysfs_ops	= &uv_port_sysfs_ops,
>  	.default_groups	= uv_port_groups,
> @@ -528,7 +528,7 @@ static const struct sysfs_ops uv_pci_top_sysfs_ops = {
>  	.show = pci_top_type_show,
>  };
> 
> -static struct kobj_type uv_pci_top_attr_type = {
> +static const struct kobj_type uv_pci_top_attr_type = {
>  	.release	= uv_pci_top_release,
>  	.sysfs_ops	= &uv_pci_top_sysfs_ops,
>  };
> 
> --
> 2.39.1