linux-kernel - Re: [PATCH V2 1/6] rtla/osnoise: Add helper functions to manipulate osnoise/options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af58737f-1d0f-06f3-be68-8b5cae284cf0@kernel.org>
Date:   Tue, 7 Feb 2023 21:04:03 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jonathan Corbet <corbet@....net>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        linux-trace-devel@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/6] rtla/osnoise: Add helper functions to manipulate
 osnoise/options

On 2/1/23 20:23, Steven Rostedt wrote:
> On Tue, 31 Jan 2023 17:30:02 +0100
> Daniel Bristot de Oliveira <bristot@...nel.org> wrote:
> 
>> Add some helper functions to read and set the on/off osnoise/options.
>> No usage in this patch.
>>
>> In preparation for hwnoise tool.
> 
> Honestly, I don't see why patches 1-5 isn't a single patch. It's not that
> big of a change, and everything in 1-5 is to do what 5 does. Breaking it up
> this fine grain isn't helpful in reviewing, as I found that I had to apply
> 1-5 and then do a diff from where I started to make sense of any of it.

Maybe what is missing is a clear:

In preparation for hwnoise tool.

IMHO, it is easier to understand by using small "logical" pieces in preparation
for the "conclusion." But I see your point, and it does not hurt :-).

I will reduce the number of patches.

-- Daniel
> 
> -- Steve
> 
> 
>>
>> Signed-off-by: Daniel Bristot de Oliveira <bristot@...nel.org>
>> Cc: Daniel Bristot de Oliveira <bristot@...nel.org>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Jonathan Corbet <corbet@....net>
>> ---
>>