linux-kernel - Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2023 08:36:47 +0800
From:   Zhou Furong <furong.zhou@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Martin Zaťovič <m.zatovic1@...il.com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, martin.petersen@...cle.com,
        beanhuo@...ron.com, arnd@...db.de, avri.altman@....com,
        iwona.winiarska@...el.com, fmdefrancesco@...il.com,
        dipenp@...dia.com, ogabbay@...nel.org, bvanassche@....org,
        mathieu.poirier@...aro.org, yangyicong@...ilicon.com,
        dan.j.williams@...el.com, devicetree@...r.kernel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver



On 2023/2/6 18:26, Greg KH wrote:
> On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote:
>>
>>>> +
>>>> +#include <linux/device.h>
>>>> +#include <linux/module.h>
>>>> +#include <linux/of.h>
>>>> +#include <linux/of_device.h>
>>>> +#include <linux/slab.h>
>>>> +#include <linux/wiegand.h>
>>>> +#include <linux/dma-mapping.h>
>>>> +#include <linux/dmaengine.h>
>>>> +#include <linux/property.h>
>>>> +
>>
>> please order headers
> 
> Why?  What order?  For what gain >

If all header file ordered in alphabet, it will be easy to find if a 
header file has been included or not when header file list is long.