linux-kernel - Re: [PATCH 0/6] staging: r8188eu: remove intf_start and intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bed49e26-bebe-bcd9-e69d-45981b86bf4e@gmail.com>
Date:   Tue, 7 Feb 2023 07:13:50 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] staging: r8188eu: remove intf_start and intf_stop

On 2/6/23 21:17, Martin Kaiser wrote:
> Remove the two pointers to media-specific start and stop functions. The
> r8188eu driver supports only usb.
> 
> Update some of the functions in the start and stop paths to return
> standard error codes instead of _SUCCESS and _FAIL.
> 
> Martin Kaiser (6):
>    staging: r8188eu: pass a struct recv_buf to rtw_read_port
>    staging: r8188eu: use standard error codes in rtw_read_port
>    staging: r8188eu: use standard error codes in rtl8188eu_inirp_init
>    staging: r8188eu: remove intf_start pointer
>    staging: r8188eu: handle rtl8188eu_inirp_init errors
>    staging: r8188eu: remove intf_stop pointer
> 
>   drivers/staging/r8188eu/hal/usb_halinit.c   | 16 ++++++--------
>   drivers/staging/r8188eu/hal/usb_ops_linux.c | 20 ++++++++---------
>   drivers/staging/r8188eu/include/drv_types.h |  2 --
>   drivers/staging/r8188eu/include/hal_intf.h  |  2 +-
>   drivers/staging/r8188eu/include/rtw_io.h    |  2 +-
>   drivers/staging/r8188eu/os_dep/os_intfs.c   | 12 +++++------
>   drivers/staging/r8188eu/os_dep/usb_intf.c   | 24 +++------------------
>   7 files changed, 26 insertions(+), 52 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150