linux-kernel - Re: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mt5pucrm.fsf@geanix.com>
Date:   Tue, 07 Feb 2023 08:59:25 +0100
From:   esben@...nix.com
To:     Jonas Suhr Christensen <jsc@...raculum.org>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michal Simek <michal.simek@...inx.com>,
        Harini Katakam <harini.katakam@....com>,
        Haoyue Xu <xuhaoyue1@...ilicon.com>,
        huangjunxian <huangjunxian6@...ilicon.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Yang Yingliang <yangyingliang@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] net: ll_temac: Reset buffer on
 dma_map_single() errors

Jonas Suhr Christensen <jsc@...raculum.org> writes:

> To avoid later calls to dma_unmap_single() on address'
> that fails to be mapped, free the allocated skb and
> set the pointer of the address to NULL. Eg. when a mapping
> fails temac_dma_bd_release() will try to call dma_unmap_single()
> on that address if the structure is not reset.
>
> Fixes: d07c849cd2b9 ("net: ll_temac: Add more error handling of dma_map_single() calls")
>
> Signed-off-by: Jonas Suhr Christensen <jsc@...raculum.org>

Acked-by: Esben Haabendal <esben@...nix.com>