linux-kernel - Re: [PATCH v2] selftests: use printf instead of echo -ne

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97df8ef0-5eef-91cd-2d6d-eeff764c5e35@collabora.com>
Date:   Tue, 7 Feb 2023 09:36:30 +0100
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Shuah Khan <shuah@...nel.org>,
        Gautam <gautammenghani201@...il.com>,
        David Laight <David.Laight@...LAB.COM>
Cc:     kernel@...labora.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernelci@...ts.linux.dev
Subject: Re: [PATCH v2] selftests: use printf instead of echo -ne

On 04/02/2023 14:56, Guillaume Tucker wrote:
> On some systems, the default echo command doesn't handle the -e option
> and the output looks like this (arm64 build):
> 
> -ne Emit Tests for alsa
> 
> -ne Emit Tests for amd-pstate
> 
> -ne Emit Tests for arm64
> 
> This is for example the case with the KernelCI Docker images
> e.g. kernelci/gcc-10:x86-kselftest-kernelci.  To avoid this issue, use
> printf which handles escape characters as a standard feature and is
> more widespread among modern shells.
> 
> The output is now formatted as expected (x86 build this time):
> 
> Emit Tests for alsa
> Emit Tests for amd-pstate
> Skipping non-existent dir: arm64
> 
> Reported-by: "kernelci.org bot" <bot@...nelci.org>
> Suggested-by: David Laight <David.Laight@...LAB.COM>
> Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile")
> Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>
> ---
> 
> Notes:
>     v2: use printf insead of $(which echo)

Oh I see you've already applied the v1 on kselftest/next branch:

  79c16b1120fe selftests: find echo binary to use -ne options

Do you want me to send this printf fix rebased on top?

Thanks,
Guillaume