linux-kernel - Re: [PATCH 3/3] soc: qcom: socinfo: add support for SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mex6jgEhGQefk8KQLdb90hqptwhdBSqs-_f_PazEmgHTQ@mail.gmail.com>
Date:   Tue, 7 Feb 2023 11:49:29 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 3/3] soc: qcom: socinfo: add support for SA8775P

On Tue, Feb 7, 2023 at 11:46 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 07/02/2023 11:07, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Add SocInfo support for SA8775P.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> >  drivers/soc/qcom/socinfo.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> > index 3b970a80f3aa..c5208aa99125 100644
> > --- a/drivers/soc/qcom/socinfo.c
> > +++ b/drivers/soc/qcom/socinfo.c
> > @@ -419,6 +419,7 @@ static const struct soc_id soc_id[] = {
> >       { qcom_board_id(SM8350) },
> >       { qcom_board_id(SM6115) },
> >       { qcom_board_id(SC8280XP) },
> > +     { qcom_board_id(SA8775P) },
>
> This does not look like correctly ordered.
>

Ugh, I missed the fact that these are ordered by the chip ID that's
defined elsewhere. Thanks, will fix that in v2.

Bart