lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Feb 2023 17:41:54 -0800 From: Saravana Kannan <saravanak@...gle.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Sudeep Holla <sudeep.holla@....com>, Cristian Marussi <cristian.marussi@....com>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>, Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Daniel Scally <djrscally@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Len Brown <lenb@...nel.org>, Saravana Kannan <saravanak@...gle.com>, "Rafał Miłecki" <rafal@...ecki.pl> Cc: Abel Vesa <abel.vesa@...aro.org>, Alexander Stein <alexander.stein@...tq-group.com>, Tony Lindgren <tony@...mide.com>, Geert Uytterhoeven <geert@...ux-m68k.org>, John Stultz <jstultz@...gle.com>, Doug Anderson <dianders@...omium.org>, Guenter Roeck <linux@...ck-us.net>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Maxim Kiselev <bigunclemax@...il.com>, Maxim Kochetkov <fido_max@...ox.ru>, Luca Weiss <luca.weiss@...rphone.com>, Colin Foster <colin.foster@...advantage.com>, Martin Kepplinger <martin.kepplinger@...i.sm>, Jean-Philippe Brucker <jpb@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, kernel-team@...roid.com, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-acpi@...r.kernel.org Subject: [PATCH v3 02/12] driver core: fw_devlink: Improve check for fwnode with no device/driver fw_devlink shouldn't defer the probe of a device to wait on a supplier that'll never have a struct device or will never be probed by a driver. We currently check if a supplier falls into this category, but don't check its ancestors. We need to check the ancestors too because if the ancestor will never probe, then the supplier will never probe either. Signed-off-by: Saravana Kannan <saravanak@...gle.com> Tested-by: Colin Foster <colin.foster@...advantage.com> Tested-by: Sudeep Holla <sudeep.holla@....com> --- drivers/base/core.c | 40 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 001e1914858d..368bfd96b511 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1867,6 +1867,35 @@ static int fw_devlink_relax_cycle(struct device *con, void *sup) return ret; } +static bool fwnode_init_without_drv(struct fwnode_handle *fwnode) +{ + struct device *dev; + bool ret; + + if (!(fwnode->flags & FWNODE_FLAG_INITIALIZED)) + return false; + + dev = get_dev_from_fwnode(fwnode); + ret = !dev || dev->links.status == DL_DEV_NO_DRIVER; + put_device(dev); + + return ret; +} + +static bool fwnode_ancestor_init_without_drv(struct fwnode_handle *fwnode) +{ + struct fwnode_handle *parent; + + fwnode_for_each_parent_node(fwnode, parent) { + if (fwnode_init_without_drv(parent)) { + fwnode_handle_put(parent); + return true; + } + } + + return false; +} + /** * fw_devlink_create_devlink - Create a device link from a consumer to fwnode * @con: consumer device for the device link @@ -1948,9 +1977,16 @@ static int fw_devlink_create_devlink(struct device *con, goto out; } - /* Supplier that's already initialized without a struct device. */ - if (sup_handle->flags & FWNODE_FLAG_INITIALIZED) + /* + * Supplier or supplier's ancestor already initialized without a struct + * device or being probed by a driver. + */ + if (fwnode_init_without_drv(sup_handle) || + fwnode_ancestor_init_without_drv(sup_handle)) { + dev_dbg(con, "Not linking %pfwP - Might never probe\n", + sup_handle); return -EINVAL; + } /* * DL_FLAG_SYNC_STATE_ONLY doesn't block probing and supports -- 2.39.1.519.gcb327c4b5f-goog
Powered by blists - more mailing lists