[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0713672c-37fe-663b-11a4-0baf02c11e6b@collabora.com>
Date: Tue, 7 Feb 2023 12:51:44 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: mturquette@...libre.com, sboyd@...nel.org, matthias.bgg@...il.com,
johnson.wang@...iatek.com, miles.chen@...iatek.com,
chun-jie.chen@...iatek.com, daniel@...rotopia.org,
fparent@...libre.com, msp@...libre.com, nfraprado@...labora.com,
rex-bc.chen@...iatek.com, zhaojh329@...il.com,
sam.shih@...iatek.com, edward-jw.yang@...iatek.com,
yangyingliang@...wei.com, granquet@...libre.com,
pablo.sun@...iatek.com, sean.wang@...iatek.com,
chen.zhong@...iatek.com, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v1 16/45] clk: mediatek: mt8167: Convert to
mtk_clk_simple_{probe,remove}()
Il 07/02/23 09:07, Chen-Yu Tsai ha scritto:
> On Mon, Feb 6, 2023 at 11:30 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>>
>> Convert topckgen and infracfg clock drivers to use the common
>> mtk_clk_simple_probe() mechanism and change this from the old
>> "static" CLK_OF_DECLARE to be a platform driver, allowing it
>> to eventually be built as a module.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>
> Code looks OK, but vdecsys converted to builtin_platform_driver() while
> the others to module_platform_driver(). This deserves an explanation.
>
There's nothing to be explained, other than this being a big overlook... :-P
Fixed that for v2, vdec deserves the module_platform_driver() treatment too!
Cheers,
Angelo
Powered by blists - more mailing lists