linux-kernel - Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8337e4a3-a25b-aa1a-9409-6fe1fb4ea84e@linaro.org>
Date:   Tue, 7 Feb 2023 13:59:57 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Zhou Furong <furong.zhou@...ux.intel.com>
Cc:     Martin Zaťovič <m.zatovic1@...il.com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, martin.petersen@...cle.com,
        beanhuo@...ron.com, arnd@...db.de, avri.altman@....com,
        iwona.winiarska@...el.com, fmdefrancesco@...il.com,
        dipenp@...dia.com, ogabbay@...nel.org, bvanassche@....org,
        mathieu.poirier@...aro.org, yangyicong@...ilicon.com,
        dan.j.williams@...el.com, devicetree@...r.kernel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver

On 07/02/2023 07:08, Greg KH wrote:
> On Tue, Feb 07, 2023 at 08:36:47AM +0800, Zhou Furong wrote:
>>
>>
>> On 2023/2/6 18:26, Greg KH wrote:
>>> On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote:
>>>>
>>>>>> +
>>>>>> +#include <linux/device.h>
>>>>>> +#include <linux/module.h>
>>>>>> +#include <linux/of.h>
>>>>>> +#include <linux/of_device.h>
>>>>>> +#include <linux/slab.h>
>>>>>> +#include <linux/wiegand.h>
>>>>>> +#include <linux/dma-mapping.h>
>>>>>> +#include <linux/dmaengine.h>
>>>>>> +#include <linux/property.h>
>>>>>> +
>>>>
>>>> please order headers
>>>
>>> Why?  What order?  For what gain >
>>
>> If all header file ordered in alphabet, it will be easy to find if a header
>> file has been included or not when header file list is long.
> 
> That's what search in your editor is for :)
> 
> This is not a real problem with this code, sorry.

I would say the only argument is reducing conflicts for simultaneous
edits, mostly when adding new headers. If everyone add at the end, you
get conflicts which could not happen if entries were ordered.

Another thing is that actual order allows easier to spot duplicates or
unneeded headers by looking. At least to me it's easier to read.

Best regards,
Krzysztof