linux-kernel - Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230207015148.55678-1-blarson@amd.com>
Date:   Mon, 6 Feb 2023 17:51:48 -0800
From:   Brad Larson <blarson@....com>
To:     <arnd@...db.de>
CC:     <adrian.hunter@...el.com>, <alcooperx@...il.com>,
        <andy.shevchenko@...il.com>, <blarson@....com>, <brad@...sando.io>,
        <brendan.higgins@...ux.dev>, <briannorris@...omium.org>,
        <brijeshkumar.singh@....com>, <broonie@...nel.org>,
        <catalin.marinas@....com>, <davidgow@...gle.com>,
        <devicetree@...r.kernel.org>, <fancer.lancer@...il.com>,
        <gerg@...ux-m68k.org>, <gsomlo@...il.com>, <krzk@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <lee.jones@...aro.org>,
        <lee@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, <p.yadav@...com>,
        <p.zabel@...gutronix.de>, <piotrs@...ence.com>,
        <rdunlap@...radead.org>, <robh+dt@...nel.org>,
        <samuel@...lland.org>, <skhan@...uxfoundation.org>,
        <suravee.suthikulpanit@....com>, <thomas.lendacky@....com>,
        <tonyhuang.sunplus@...il.com>, <ulf.hansson@...aro.org>,
        <vaishnav.a@...com>, <will@...nel.org>,
        <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset

On Thu, Jan 19, 2023, at 09:57, Arnd Bergmann wrote:
> On Thu, Jan 19, 2023, at 04:39, Brad Larson wrote:
>> 
>> +extern unsigned int sdhci_timeout_val;
>> +
>
> This declaration should not be in the .c file, and I don't think
> there should be a global variable with this overly generic name either.

Thanks for pointing this out, I've deleted that line.  It was leftover test
code to force a timeout to trigger the reset driver and reset the timeout.

Regards,
Brad