linux-kernel - Re: [PATCH 2/3] nolibc: Add support for LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 07 Feb 2023 15:25:50 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     chris.chenfeiyang@...il.com, w@....eu,
        "Paul E. McKenney" <paulmck@...nel.org>
Cc:     "Feiyang Chen" <chenfeiyang@...ngson.cn>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] nolibc: Add support for LoongArch

On Tue, Feb 7, 2023, at 03:09, chris.chenfeiyang@...il.com wrote:
> From: Feiyang Chen <chenfeiyang@...ngson.cn>
>
> Add support for LoongArch (32 and 64 bit) to nolibc.
>
> Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
> ---
> +
> +struct sys_stat_struct {
> +	unsigned long	st_dev;		/* Device.  */
> +	unsigned long	st_ino;		/* File serial number.  */
> +	unsigned int	st_mode;	/* File mode.  */
> +	unsigned int	st_nlink;	/* Link count.  */
> +	unsigned int	st_uid;		/* User ID of the file's owner.  */
> +	unsigned int	st_gid;		/* Group ID of the file's group. */
> +	unsigned long	st_rdev;	/* Device number, if device.  */
> +	unsigned long	__pad1;
> +	long		st_size;	/* Size of file, in bytes.  */
> +	int		st_blksize;	/* Optimal block size for I/O.  */
> +	int		__pad2;
> +	long		st_blocks;	/* Number 512-byte blocks allocated. */
> +	long		st_atime;	/* Time of last access.  */
> +	unsigned long	st_atime_nsec;
> +	long		st_mtime;	/* Time of last modification.  */
> +	unsigned long	st_mtime_nsec;
> +	long		st_ctime;	/* Time of last status change.  */
> +	unsigned long	st_ctime_nsec;
> +	unsigned int	__unused4;
> +	unsigned int	__unused5;
> +};

This definition should not be used after patch 1, I think you
should drop it.

      Arnd