[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230208180007.GB2397622@hu-bjorande-lv.qualcomm.com>
Date: Wed, 8 Feb 2023 10:00:07 -0800
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
CC: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: Introduce pmic_glink
On Wed, Feb 08, 2023 at 05:40:44PM +0100, Konrad Dybcio wrote:
> On 8.02.2023 16:57, Bjorn Andersson wrote:
> > On Wed, Feb 08, 2023 at 09:14:46AM +0100, Konrad Dybcio wrote:
> >> On 8.02.2023 04:46, Bjorn Andersson wrote:
[..]
> >>> &usb_0_dwc3 {
> >>> - /* TODO: Define USB-C connector properly */
> >>> dr_mode = "host";
> >>> +
> >>> + port {
> >>> + usb_0_role_switch: endpoint {
> >>> + remote-endpoint = <&pmic_glink_con0_hs>;
> >>> + };
> >> This should be defined in the SoC DTSI, it's a standard dwc3 binding
> >> with usb HS / SS / SBU ports. Especially since we can feed the endpoint
> >> from any device now, as pmic-glink should work everywhere.
> >>
> >
> > The sa8295p/sa8540p boards, derived from sc8280xp does not implement
> > pmic_glink, so it seems moving this to the soc.dtsi would be messy.
> >
> >> Or /omit-if-no-ref/, I suppose.
> >>
> >
> > Or you're saying I should put the skeleton of the port definition in the
> > soc.dtsi and then fill it out the remote-endpoint here; and mark it
> > omit-if-no-ref to avoid binding warnings?
> I thought omit-if-no-ref actually omits the node before resolving phandles
> that it references, but it seems to not be the case.. Still, we can define
> the ports in the SoC DTSI and assign endpoints per-device (like we do with
> DSI for example).
>
You mean move the lines:
port {
usb_0_role_switch: endpoint {
};
};
to sc8280xp.dtsi and then do:
&usb_0_role_switch {
remote-endpoint = <&pmic_glink_con0_hs>;
};
here?
Regards,
Bjorn
Powered by blists - more mailing lists