linux-kernel - Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return FW_UPLOAD_ERR_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79d47a18-90dd-9fc2-aa0e-ca5627b7ca6d@intel.com>
Date:   Wed, 8 Feb 2023 11:28:26 -0800
From:   Russ Weight <russell.h.weight@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        "Moritz Fischer" <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
        Lee Jones <lee@...nel.org>,
        Tianfei zhang <tianfei.zhang@...el.com>,
        <linux-fpga@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return
 FW_UPLOAD_ERR_HW_ERROR


On 2/8/23 00:08, Ilpo Järvinen wrote:
> rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> FW_UPLOAD_ERR_HW_ERROR.
>
> Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Reviewed-by: Russ Weight <russell.h.weight@...el.com>

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>
> ---
>  drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> index f0acedc80182..d7e2f9f461bc 100644
> --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
>  
>  	ret = sec->ops->rsu_status(sec);
>  	if (ret < 0)
> -		return ret;
> +		return FW_UPLOAD_ERR_HW_ERROR;
>  	status = ret;
>  
>  	if (!rsu_status_ok(status)) {
>