linux-kernel - [PATCH] media: i2c: imx290: make suspend/resume functions __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  8 Feb 2023 13:19:14 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: [PATCH] media: i2c: imx290: make suspend/resume functions __maybe_unused

GCC reports that these 2 functions are defined but not used, so mark
them as __maybe_unused to pacify the build.

drivers/media/i2c/imx290.c:1090:12: warning: 'imx290_runtime_suspend' defined but not used [-Wunused-function]
 1090 | static int imx290_runtime_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~
drivers/media/i2c/imx290.c:1082:12: warning: 'imx290_runtime_resume' defined but not used [-Wunused-function]
 1082 | static int imx290_runtime_resume(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~

Fixes: 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
---
 drivers/media/i2c/imx290.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -1079,7 +1079,7 @@ static void imx290_power_off(struct imx2
 	regulator_bulk_disable(ARRAY_SIZE(imx290->supplies), imx290->supplies);
 }
 
-static int imx290_runtime_resume(struct device *dev)
+static int __maybe_unused imx290_runtime_resume(struct device *dev)
 {
 	struct v4l2_subdev *sd = dev_get_drvdata(dev);
 	struct imx290 *imx290 = to_imx290(sd);
@@ -1087,7 +1087,7 @@ static int imx290_runtime_resume(struct
 	return imx290_power_on(imx290);
 }
 
-static int imx290_runtime_suspend(struct device *dev)
+static int __maybe_unused imx290_runtime_suspend(struct device *dev)
 {
 	struct v4l2_subdev *sd = dev_get_drvdata(dev);
 	struct imx290 *imx290 = to_imx290(sd);