linux-kernel - RE: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de9439e489684965989ac4e96b87de41@AcuMS.aculab.com>
Date:   Wed, 8 Feb 2023 22:39:18 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'chris.chenfeiyang@...il.com'" <chris.chenfeiyang@...il.com>,
        "w@....eu" <w@....eu>, "paulmck@...nel.org" <paulmck@...nel.org>
CC:     Feiyang Chen <chenfeiyang@...ngson.cn>,
        "arnd@...db.de" <arnd@...db.de>,
        "chenhuacai@...nel.org" <chenhuacai@...nel.org>,
        "jiaxun.yang@...goat.com" <jiaxun.yang@...goat.com>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on
 statx() when available

From: chris.chenfeiyang@...il.com
> Sent: 08 February 2023 10:18
> 
> loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> openrisc have statx() and stat64() but not stat() or newstat().
> Add statx() and make stat() rely on statx() to make them happy.
> 
...
> +#ifdef __NR_statx
> +static __attribute__((unused))
> +int sys_stat(const char *path, struct stat *buf)
> +{
> +	struct statx stat;

If seems wrong that 'stat' has type 'struct statx'
and 'buf' type 'struct stat *'.

Maybe s/stat./statx./ and s/buf->/stat->/ ?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)