linux-kernel - Re: [PATCH 2/3] arm64: dts: qcom: ipq5332: enable the download mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230208233650.fcgsfyz6aegjsing@ripper>
Date:   Wed, 8 Feb 2023 15:36:50 -0800
From:   Bjorn Andersson <andersson@...nel.org>
To:     Kathiravan T <quic_kathirav@...cinc.com>
Cc:     agross@...nel.org, konrad.dybcio@...aro.org, lee@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: ipq5332: enable the download mode
 support

On Mon, Jan 30, 2023 at 10:31:54PM +0530, Kathiravan T wrote:
> Enable the support for download mode to collect the RAM dumps if
> system crashes, to perform the post mortem analysis.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 7f0ba2ec339c..6a1d0cc927ef 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -70,6 +70,7 @@
>  	firmware {
>  		scm {
>  			compatible = "qcom,scm-ipq5332", "qcom,scm";
> +			qcom,dload-mode = <&tcsr 0x0>;
>  		};
>  	};
>  
> @@ -142,6 +143,11 @@
>  				 <0>;
>  		};
>  
> +		tcsr: syscon@...d100 {
> +			compatible = "qcom,tcsr-ipq5332", "syscon";
> +			reg = <0x0193d100 0x4>;

Please map the entire TCSR_REGS here, and use qcom,dload-mode to encode
the offset within this.

Thanks,
Bjorn

> +		};
> +
>  		sdhc: mmc@...4000 {
>  			compatible = "qcom,ipq5332-sdhci", "qcom,sdhci-msm-v5";
>  			reg = <0x07804000 0x1000>, <0x07805000 0x1000>;
> -- 
> 2.17.1
>