linux-kernel - Re: [PATCH RESEND] PM/OPP: fix error checking in opp_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230208051226.2lp736c67fem35ex@vireshk-i7>
Date:   Wed, 8 Feb 2023 10:42:26 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Qi Zheng <zhengqi.arch@...edance.com>
Cc:     vireshk@...nel.org, nm@...com, sboyd@...nel.org,
        gregkh@...uxfoundation.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] PM/OPP: fix error checking in opp_migrate_dentry()

On 08-02-23, 12:00, Qi Zheng wrote:
> Since commit ff9fb72bc077 ("debugfs: return error values,
> not NULL") changed return value of debugfs_rename() in
> error cases from %NULL to %ERR_PTR(-ERROR), we should
> also check error values instead of NULL.
> 
> Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> ---
> Resend as a separate patch.
> 
>  drivers/opp/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c
> index 96a30a032c5f..2c7fb683441e 100644
> --- a/drivers/opp/debugfs.c
> +++ b/drivers/opp/debugfs.c
> @@ -235,7 +235,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev,
>  
>  	dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir,
>  				opp_table->dentry_name);
> -	if (!dentry) {
> +	if (IS_ERR(dentry)) {
>  		dev_err(dev, "%s: Failed to rename link from: %s to %s\n",
>  			__func__, dev_name(opp_dev->dev), dev_name(dev));
>  		return;

Applied. Thanks.

-- 
viresh