linux-kernel - Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c9af50a-f4b1-ed1a-5655-cc20fd880bf1@microchip.com>
Date:   Wed, 8 Feb 2023 09:49:33 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <ye.xingchen@....com.cn>, <lee@...nel.org>
CC:     <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

On 08.02.2023 11:31, ye.xingchen@....com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

> ---
>  drivers/mfd/atmel-flexcom.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 33caa4fba6af..b52f7ffdad35 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -37,7 +37,6 @@ struct atmel_flexcom {
>  static int atmel_flexcom_probe(struct platform_device *pdev)
>  {
>         struct device_node *np = pdev->dev.of_node;
> -       struct resource *res;
>         struct atmel_flexcom *ddata;
>         int err;
> 
> @@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
>             ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
>                 return -EINVAL;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       ddata->base = devm_ioremap_resource(&pdev->dev, res);
> +       ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>         if (IS_ERR(ddata->base))
>                 return PTR_ERR(ddata->base);
> 
> --
> 2.25.1